Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate redux reducer about dictionary #64

Merged
merged 4 commits into from
May 13, 2024
Merged

Migrate redux reducer about dictionary #64

merged 4 commits into from
May 13, 2024

Conversation

jooyeongmee
Copy link
Contributor

@jooyeongmee jooyeongmee commented May 1, 2024 •
edited
Loading

변경 사항:

  • reducers/dictionary 폴더 하위 파일들 js -> ts 로 변경

진행 상황:

  • 코드 수정
  • 테스트

특이 사항:

  • 코드 수정 중 CourseLastSearchOption 타입이 optional 처리가 빠진 것 같아 추가하였습니다.

@jooyeongmee jooyeongmee requested a review from yumincho May 1, 2024 11:31
@jooyeongmee jooyeongmee self-assigned this May 1, 2024
@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 4.50%. Comparing base (c729e98) to head (74eca5b).

❗ Current head 74eca5b differs from pull request most recent head 8121398. Consider uploading reports for the commit 8121398 to get more accurate results

Files Patch % Lines
src/reducers/dictionary/list.ts 0.00% 17 Missing and 1 partial ⚠️
src/reducers/dictionary/search.ts 0.00% 14 Missing and 1 partial ⚠️
src/reducers/dictionary/courseFocus.ts 0.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           migration     #64      +/-   ##
============================================
- Coverage       4.51%   4.50%   -0.01%     
============================================
  Files            210     210              
  Lines           6495    6501       +6     
  Branches        1743    1748       +5     
============================================
  Hits             293     293              
- Misses          6026    6036      +10     
+ Partials         176     172       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooyeongmee jooyeongmee marked this pull request as ready for review May 1, 2024 13:52
yumincho
yumincho reviewed May 3, 2024
View reviewed changes
src/reducers/dictionary/courseFocus.ts Outdated Show resolved Hide resolved
src/reducers/dictionary/list.ts Outdated Show resolved Hide resolved
@jooyeongmee jooyeongmee requested a review from yumincho May 8, 2024 13:29
@yumincho yumincho mentioned this pull request May 10, 2024
Merged
2 tasks
@yumincho yumincho changed the title migrate: reducer dictionary Migrate redux reducer about dictionary May 12, 2024
yumincho
yumincho approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@yumincho yumincho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sboh1214
sboh1214 requested changes May 12, 2024
View reviewed changes
src/reducers/dictionary/courseFocus.ts Show resolved Hide resolved
src/shapes/state/dictionary/CourseLastSearchOption.ts Show resolved Hide resolved
src/reducers/dictionary/search.ts Outdated Show resolved Hide resolved
@sboh1214 sboh1214 force-pushed the migration@reducers/dictionary branch from 2027692 to 74eca5b Compare May 13, 2024 16:52
@sboh1214 sboh1214 self-requested a review May 13, 2024 17:07
sboh1214
sboh1214 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NASA LGTM

@sboh1214 sboh1214 merged commit d0db360 into migration May 13, 2024
3 checks passed
@sboh1214 sboh1214 deleted the migration@reducers/dictionary branch May 13, 2024 17:08
@yumincho yumincho added this to the TypeScript Migration milestone May 16, 2024
@yumincho yumincho added the migrate migrate from JS CC to TS FC label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumincho yumincho yumincho approved these changes

@Davidace136 Davidace136 Davidace136 approved these changes

@sboh1214 sboh1214 sboh1214 approved these changes

@useruseruse useruseruse Awaiting requested review from useruseruse

Assignees

@jooyeongmee jooyeongmee

Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Milestone
Refactoring & Migration
Development

Successfully merging this pull request may close these issues.
4 participants
@jooyeongmee @sboh1214 @Davidace136 @yumincho